crude bbbike routing service support
Needs ReviewPublic

Authored by L29Ah on Nov 21 2016, 6:31 AM.

Details

Reviewers
nienhueser

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
L29Ah updated this revision to Diff 8337.Nov 21 2016, 6:31 AM
L29Ah retitled this revision from to crude bbbike routing service support.
L29Ah updated this object.
L29Ah edited the test plan for this revision. (Show Details)
L29Ah set the repository for this revision to R34 Marble.
nienhueser edited edge metadata.Nov 23 2016, 6:07 AM

Looks fine, thanks. We need support to determine the city in the code and confirm the appid with the bbbike.org guys in order to ship it. Otherwise just minor stuff.

src/plugins/runner/bbbike/BbbikePlugin.cpp
27

should be false.

37

Should be "BBBike" here.

52

"http://bbbike.org/ bicycle routing service" just in case people don't get it from the URL.

src/plugins/runner/bbbike/BbbikeRunner.cpp
64

I see two options to receive the city:

  • Use their API to query it at runtime, possibly cache the result for subsequent routing requests. The disadvantage is that we have to wait another time to transmit things via a possibly slow Internet connection
  • Provide a set of GeoDataLatLonBox <-> city mappings that are part of the plugin. This spares the second http calls, but has the disadvantage that the set of shipped mappings might be out of date e.g. when bbbike.org adds another supported city

Any preferences which way to go here? I kinda think the first one is better, mostly because caching the result city will reduce the disadvantages of another http query a lot.

65

Guess we still have to contact them to confirm the marble appid?