Details
Details
- Reviewers
nienhueser
Diff Detail
Diff Detail
- Repository
- R34 Marble
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Looks fine, thanks. We need support to determine the city in the code and confirm the appid with the bbbike.org guys in order to ship it. Otherwise just minor stuff.
src/plugins/runner/bbbike/BbbikePlugin.cpp | ||
---|---|---|
27 | should be false. | |
37 | Should be "BBBike" here. | |
52 | "http://bbbike.org/ bicycle routing service" just in case people don't get it from the URL. | |
src/plugins/runner/bbbike/BbbikeRunner.cpp | ||
64 | I see two options to receive the city:
Any preferences which way to go here? I kinda think the first one is better, mostly because caching the result city will reduce the disadvantages of another http query a lot. | |
65 | Guess we still have to contact them to confirm the marble appid? |