[libinput] Query default left handed and save left handed property, write correct touchpad scroll mode entry, code style
ClosedPublic

Authored by romangg on Nov 20 2016, 11:25 PM.

Details

Summary

Some small adjustments to the libinput backend:

  • Query libinput_device_config_left_handed_get_default
  • Write leftHanded property to config file
  • When saving the touchpad scroll mode, we need to write false to all other ones. Otherwise it will always enable the upmost entry after reboot (maybe writing an enum here would be cleaner).
  • Use macro for setLeftHanded(bool) and setNaturalScroll(bool)
Test Plan

Tested the scroll mode setting on a Wayland session through dbus commands.

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
romangg updated this revision to Diff 8335.Nov 20 2016, 11:25 PM
romangg retitled this revision from to [libinput] Query default left handed property, write correct touchpad scroll mode entry, code style.
romangg updated this object.
romangg edited the test plan for this revision. (Show Details)
romangg added reviewers: KWin, graesslin, strobach.
romangg set the repository for this revision to R108 KWin.
romangg added a project: KWin.
Restricted Application added a subscriber: kwin. · View Herald TranscriptNov 20 2016, 11:25 PM
graesslin edited edge metadata.Nov 21 2016, 8:05 AM

Please also add a testcase to test the behavior in the device test

romangg retitled this revision from [libinput] Query default left handed property, write correct touchpad scroll mode entry, code style to [libinput] Query default left handed and save left handed property, write correct touchpad scroll mode entry, code style.Nov 21 2016, 5:18 PM
romangg updated this object.
romangg edited edge metadata.
romangg updated this revision to Diff 8349.Nov 21 2016, 5:20 PM

Added autotest for leftHandedEnabledByDefault.

romangg updated this revision to Diff 8375.Nov 22 2016, 8:15 AM

Revision update didn't work last time, now also added autotest testLoadLeftHanded.

graesslin accepted this revision.Nov 22 2016, 11:57 AM
graesslin edited edge metadata.
This revision is now accepted and ready to land.Nov 22 2016, 11:57 AM
This revision was automatically updated to reflect the committed changes.