Browse Archives As Folders option applied to iso files
ClosedPublic

Authored by martinkostolny on Nov 20 2016, 11:24 PM.

Details

Summary

This patch enforces "ArchivesAsDirectories" setting to be applied to iso files as well as files opened with krarc protocol.

This is a follow-up of Davide's comment https://phabricator.kde.org/D2603#63992. Please feel free to criticize or dump this solution in favour of another:).

Test Plan
  • with "Browse Archives as Folders" enabled:
    • check that zip and iso files are browsed by pressing enter
    • e.g. epub files are opened in external viewer (e.g. okular) by pressing enter
  • with "Browse Archives as Folders" disabled:
    • check thet zip and iso files are opened in ark by pressing enter
    • e.g. epub files are opened in external viewer (e.g. okular) by pressing enter

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martinkostolny retitled this revision from to Browse Archives As Folders option applied to iso files.
martinkostolny updated this object.
martinkostolny edited the test plan for this revision. (Show Details)
martinkostolny added a reviewer: Krusader.
martinkostolny set the repository for this revision to R167 Krusader.
martinkostolny added a project: Krusader.
abika accepted this revision.Dec 4 2016, 6:06 PM
abika added a reviewer: abika.
abika added a subscriber: abika.

Ship it!

( theFileCanBeExecutedOrOpenedWithOtherSoftware comments dont belong into variable names :)

This revision is now accepted and ready to land.Dec 4 2016, 6:06 PM
This revision was automatically updated to reflect the committed changes.

comments dont belong into variable names :)

Agreed & fixed.