BUG:372545
Details
Details
- Reviewers
kamathraghavendra timotheegiet woltherav - Group Reviewers
Krita - Commits
- R37:1a40dc01c326: Fix compilation due to undefined M_PI on some compilers
R37:f64193a62dbe: Fix KisBrushOpTest
R37:1deab2673eca: Fix isotropic spacing when working on a mirrored canvas
R37:1b88a3d2886a: Fix Tilt-elevation to work with rotated/mirrored canvas
R37:c6e230ca8436: Fix isotropic spacing when working on a mirrored canvas
This patch touches rotation and mirroring capabilities of the brushes. These
parameters depend on both, brush and canvas rotation/mirroring capabilities,
so they should be tested in complex.
- Test with rotated (or drawing angle) brushes
- Test with mirrored (including using sensor) brushes
- Test with rotated canvas
- Test with mirrored canvas
- Test with all combinations of the above :)
The general idea of canvas rotation/mirroring is:
Whenever you rotate or mirror the canvas, brush shape *doesn't* change
its shape from your point of view. That is if you paint with a
vertical rectangular brush, the brush should still stay vertical
whenever you rotate/miror the canvas. In other words, the brush shape
is linked to your stylus tip, not to the canvas.
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Test result: everything in the test plan works fine :)
The only little annoying detail is when rotating, the brush outline cursor is rotated until it gets some input/starts moving.
Also, I was hoping this would fix the rotation bug with tilt, but it doesn't..
Could you please take a look at it?
https://bugs.kde.org/show_bug.cgi?id=366289
https://bugs.kde.org/show_bug.cgi?id=369451
(I also pasted the duplicate bug link as my comments there are important...)
Comment Actions
Oh, and as I said on irc, I had a build error : ‘M_PI’ was not declared in this scope .
So I added
#ifndef M_PI
#define M_PI 3.14159265358979323846
#endif
in kis_distance_information.h to make it build.
Comment Actions
- Fix KisBrushOpTest
- Fix Tilt-elevation to work with rotated/mirrored canvas
- Fix compilation due to undefined M_PI on some compilers
Comment Actions
Hi, @timotheegiet!
I've fixed the tilt-rotation bug you mentioned. Please test and report if it really fixes the problem for you! :)
Comment Actions
Yay! Works perfectly, tilt problem solved. Congrats!
Please ship it :)
(tested on 3.1 branch only...)