Fix AbstractClient::sizeForClientSize

Authored by graesslin on Nov 18 2016, 11:36 AM.



The method is supposed to return the AbstractClient's size for a given
client size. That is the size including the window decoration.

The default implementation returned the passed in client size without
adjusting for the decoration. This resulted in ShellClient getting a
wrong size especially when AbstractClient::adjustedClientSize (which
calls sizeForClientSize) was called.

The result of the incorrect size was for example a shrinking of the
window when starting to resize a window.

BUG: 370345
FIXED-IN: 5.8.4

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8302.Nov 18 2016, 11:36 AM
graesslin retitled this revision from to Fix AbstractClient::sizeForClientSize.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptNov 18 2016, 11:36 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Nov 18 2016, 12:53 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Nov 18 2016, 12:53 PM
broulik accepted this revision.Nov 18 2016, 2:11 PM
broulik edited edge metadata.
This revision was automatically updated to reflect the committed changes.