Cyanogenmod Tiles
AbandonedPublic

Authored by nicolasfella on Nov 16 2016, 12:06 AM.

Details

Summary

Added a tile for launch commands from notification bar

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Lint Skipped
Unit
Unit Tests Skipped
menasshock updated this revision to Diff 8188.Nov 16 2016, 12:06 AM
menasshock retitled this revision from to Cyanogenmod Tiles.
menasshock updated this object.
menasshock edited the test plan for this revision. (Show Details)
menasshock set the repository for this revision to R225 KDE Connect - Android application.
albertvaka edited edge metadata.Nov 18 2016, 4:24 PM

Minor issues, but looks good. The only problem is about using API 25 (see below), is it really needed for this to work?

build.gradle
17

If I remember correctly, one can't publish apps to the Play Store with targetSdk > 23 if they don't support the new permissions model :( If API 25 is needed, that means that we will need to change to discrete permissions first...

57–59

Don't make this change part of the diff. I'ts disabled so builds are faster in debug.

src/org/kde/kdeconnect/Plugins/RunCommandPlugin/RunCommandPlugin.java
50

Rename to EXTRA_RUNCOMMAND_DEVICEID or something like that, to differentiate it from PACKAGE_TYPE_RUNCOMMAND and PACKAGE_TYPE_RUNCOMMAND_REQUEST. These two are "command types" and are used for a different purpose.

53–62

Don't commit whitespace changes as part of a new feature.

105

Did you remove this for a reason, or was unintended?

134–168

This could be moved to a separate function, so we split Cyanogen code from all-platforms code.

Also, I've never used the Cyanogen API, but I'm curious about this: don't we need to guard it with an "if (device_is_cyanogen)" or something like that? Will it just run without effect on other Androids?

Is this still relevant?

I would appreciate this.

nicolasfella added a subscriber: nicolasfella.EditedMar 15 2018, 8:14 PM

I would appreciate this.

Would you please test it thoroughly? Let us know if you need help with this.

I don't use Cyanogen/Lineage anymore, so I can't really give my opinion about it

I would appreciate this.

Would you please test it thoroughly? Let us know if you need help with this.

I don't use Cyanogen/Lineage anymore, so I can't really give my opinion about it

I would test this but I can't find what is:

MaterialActivity.class

in

int intentIndex = 0;
Intent activityIntent = new Intent( context, MaterialActivity.class );
activityIntent.setFlags( Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK );

Maybe you could please tell me what was it renamed to?

Maybe you could please tell me what was it renamed to?

It's been renamed to MainActivity.

By the way, is this different from the Android Quick tiles (https://developer.android.com/reference/android/service/quicksettings/TileService.html)? If so, what are the advantages of this code, assuming it's LineageOS only?

It should work on API19 (Kitkat) too unlike TileService that's minAPI 24? I'm going to try and test if it actually does as soon as possible.

Okay, so, for some reason I can't get the tiles to appear on my LOS11 device and I can't find any proper documentation if it even should. Someone on a newer version of LOS could try this out.

I think newer versions of LineageOS just use regular Android tiles. Closing this, as it was only for old CyanogenOS versions.

nicolasfella commandeered this revision.Mar 23 2018, 6:43 PM
nicolasfella abandoned this revision.
nicolasfella added a reviewer: menasshock.