Differential D3339

[effects] Drop loading shadow config from MagicLamp
ClosedPublic
Actions

Authored by graesslin on Nov 11 2016, 10:15 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
KWin
Commits
R108:a8fa1626eb9d: [effects] Drop loading shadow config from MagicLamp
Summary

This has basically been dead code for ages. The Shadow effect got
dropped in an early 4.x version. We shouldn't transform the window based
on old shadow values, so completely removed.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 8088.Nov 11 2016, 10:15 AM
graesslin retitled this revision from to [effects] Drop loading shadow config from MagicLamp.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptNov 11 2016, 10:15 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Nov 11 2016, 12:34 PM
mart added a reviewer: mart.
mart added a subscriber: mart.

+1 for spring cleanings

This revision is now accepted and ready to land.Nov 11 2016, 12:34 PM
Closed by commit R108:a8fa1626eb9d: [effects] Drop loading shadow config from MagicLamp (authored by graesslin). · Explain WhyNov 15 2016, 6:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8144

View Options

effects/magiclamp/magiclamp.h

Loading...
View Options

effects/magiclamp/magiclamp.cpp

Loading...