Words: Do not open a "Connect Text Frame" pane to non-text shapes
ClosedPublic

Authored by danders on Nov 5 2016, 2:07 PM.

Details

Summary

This crashes non-text frames like the chart shape

Words: Check if at least one shape is selected before opening edit dialog

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders updated this revision to Diff 7920.Nov 5 2016, 2:07 PM
danders retitled this revision from to Words: Do not open a "Connect Text Frame" pane to non-text shapes.
danders updated this object.
danders edited the test plan for this revision. (Show Details)
danders added a reviewer: boemann.
Restricted Application added projects: KEXI, Calligra: 3.0. · View Herald TranscriptNov 5 2016, 2:07 PM
boemann accepted this revision.Nov 7 2016, 1:52 PM
boemann edited edge metadata.

Looks good

This revision is now accepted and ready to land.Nov 7 2016, 1:52 PM
This revision was automatically updated to reflect the committed changes.