ProblemModelSet: use ids instead names for problems find, remove, show
ClosedPublic
Actions

Authored by antonanikin on Oct 28 2016, 12:23 PM.

Details

Reviewers

None

Group Reviewers

Commits

R33:0accce136675: ProblemModelSet: use ids instead names for problems find, remove, show
R32:0accce136675: ProblemModelSet: use ids instead names for problems find, remove, show

Summary

This patch adds id field to ModelData and uses it for problems manage. This is more correct way which allows us to use translated problem model names and don't think about translation troubles during common operations.

Test Plan

Tested on master branch. Also tested with some plugins (needs code update): kdev-clangtidy, kdev-cppcheck, kdev-valgrind, kdev-verapp

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

antonanikin updated this revision to Diff 7723.Oct 28 2016, 12:23 PM

antonanikin retitled this revision from to ProblemModelSet: use ids instead names for problems find, remove, show.

antonanikin updated this object.

antonanikin edited the test plan for this revision. (Show Details)

antonanikin added a reviewer: KDevelop.

antonanikin added a subscriber: kdevelop-devel.

Small codestyle fixes

Closed by commit R33:0accce136675: ProblemModelSet: use ids instead names for problems find, remove, show (authored by antonanikin). · Explain WhyNov 2 2016, 3:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/problemreporter/problemreporterplugin.h (2 lines)
M			plugins/problemreporter/problemreporterplugin.cpp (6 lines)
M			plugins/problemreporter/problemsview.h (5 lines)
M			plugins/problemreporter/problemsview.cpp (73 lines)
M			plugins/problemreporter/tests/test_problemsview.cpp (12 lines)
M			shell/problemmodelset.h (19 lines)
M			shell/problemmodelset.cpp (25 lines)
M			shell/tests/test_problemmodelset.cpp (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7723	bccdb75		Oct 28 2016, 12:23 PM	★	★
Diff 2	7807	72a603d	- Small codestyle fixes	Nov 2 2016, 3:10 AM	★	★
Diff 3	7808	5effcc1	rKDEVPLATFORM0accce136675a2247d867d95fabd7e58debb3d9b	Nov 2 2016, 3:44 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
13df351645e9	0d27c23c2761	65248c3cebb4	Anton Anikin	Small codestyle fixes	Nov 2 2016, 3:07 AM
65248c3cebb4	7ddc881b2b15	72a603d246b3	Anton Anikin	ProblemModelSet: use ids instead names for problems find, remove, show (Show More…)	Oct 28 2016, 11:08 AM