Add support for desktopFileName provided by NETWinInfo
ClosedPublic

Authored by graesslin on Oct 27 2016, 2:05 PM.

Details

Summary

KWindowSystem provides a KDE specific property for the desktop file
name. This allows KWin to take the icon from the desktop file. The
advantage from the desktop file is that KWin normally gets higher
resolution icons than provided through the xproperty based icons used
previously. If the desktop file does not provide an icon name, KWin
falls back to the previous implementation.

As on Wayland the icon is taken from the desktop file name already the
code for X11 and Wayland is merged in AbstractClient. Also to the
PlasmaWindowInterface the appId is taken from the new desktop file
instead of the resourceName. Due to that for Xwayland windows where KWin
knows the desktop file name it can be passed to PlasmaWindowInterface.
This allows e.g. the task manager to better map the windows to
applications and provide better icons. Also it means that icons do not
need to be passed as bitmap data to the clients.

Test Plan

Verified that icon is taking from desktop file if provided and
from X property if not provided and that Wayland windows still have icon.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7699.Oct 27 2016, 2:05 PM
graesslin retitled this revision from to Add support for desktopFileName provided by NETWinInfo.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland, hein.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptOct 27 2016, 2:05 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
hein accepted this revision.Oct 28 2016, 6:49 AM
hein edited edge metadata.
This revision is now accepted and ready to land.Oct 28 2016, 6:49 AM
This revision was automatically updated to reflect the committed changes.