Move brush unit tests to ecm
ClosedPublic

Authored by gladhorn on Oct 26 2016, 2:05 PM.

Details

Summary

This actually makes it less boiler plate heavy. It's an experiment, if
this is accepted, I'd propose moving all other tests over too.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn updated this revision to Diff 7673.Oct 26 2016, 2:05 PM
gladhorn retitled this revision from to Move brush unit tests to ecm.
gladhorn updated this object.
gladhorn edited the test plan for this revision. (Show Details)
gladhorn added a reviewer: Krita.
rempt added a subscriber: rempt.EditedOct 26 2016, 2:17 PM

I'm fine with this -- it's just that it's so much work that I never considered doing it myself :-)

Oh: one gotach -- does the code we use to mark unittests as known broken still work with this change?

I don't think there is a flag for the broken state. But there is a more verbose option that should work (similar to the three liner you have now for each test). That version is needed anyway when tests have special requirements. But I think it's nice to have only one line per test in the common case.

This revision was automatically updated to reflect the committed changes.