This actually makes it less boiler plate heavy. It's an experiment, if
this is accepted, I'd propose moving all other tests over too.
Details
Details
- Reviewers
- None
- Group Reviewers
Krita - Commits
- R37:27d0b63e3431: cmake: use cmake-extra-modules for Unit Tests
R37:16b41f329510: Move brush unit tests to ecm
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I'm fine with this -- it's just that it's so much work that I never considered doing it myself :-)
Oh: one gotach -- does the code we use to mark unittests as known broken still work with this change?
Comment Actions
I don't think there is a flag for the broken state. But there is a more verbose option that should work (similar to the three liner you have now for each test). That version is needed anyway when tests have special requirements. But I think it's nice to have only one line per test in the common case.