allow changing an output's modelist at runtime This should fix running Plasma in a windowed virtual machine, when the window is resized, the mode list changes, and libksreen can't currently handle that.
ClosedPublic
Actions

Authored by sebas on Oct 19 2016, 9:40 PM.

Details

Reviewers

Group Reviewers

Commits

R110:7367e55b7c17: allow changing an output's modelist at runtime
R110:6cc05cae8143: allow changing an output's modelist at runtime

Summary

make Output::modes() non CONSTANT, add modesChanged() signal
compare the mode lists and set the new one
queue an outputChanged signal when applied
autotest for modelist changes
update the mode list on RRNotify events

BUG:356864

Test Plan

for library part, autotests are added
for xrandr backends, we can't sensibly autotest this :(

Diff Detail

Repository

R110 KScreen Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

sebas updated this revision to Diff 7555.Oct 19 2016, 9:40 PM

sebas retitled this revision from to allow changing an output's modelist at runtime This should fix running Plasma in a windowed virtual machine, when the window is resized, the mode list changes, and libksreen can't currently handle that..

sebas updated this object.

sebas edited the test plan for this revision. (Show Details)

sebas added a reviewer: Plasma.

sebas added a subscriber: graesslin.

Restricted Application added a project: Plasma. · View Herald TranscriptOct 19 2016, 9:40 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

This would go together with https://phabricator.kde.org/D2155 .

mart accepted this revision.Oct 20 2016, 9:23 AM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Oct 20 2016, 9:23 AM

Closed by commit R110:6cc05cae8143: allow changing an output's modelist at runtime (authored by sebas). · Explain WhyOct 20 2016, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (1 line)
A	M	autotests/testmodelistchange.cpp (179 lines)
M		backends/xrandr/xrandroutput.cpp (10 lines)
M		src/output.h (10 lines)
M		src/output.cpp (37 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7555	d8ae0a2		Oct 19 2016, 9:40 PM	★	★
Diff 2	7579	d8ae0a2	rLIBKSCREEN6cc05cae8143bf2a1f50389f39cc7976ac7030b7	Oct 20 2016, 10:07 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
e887c25252d0	515180ab2784	f2d1dad786c3	Sebastian Kügler	Cleanups	Oct 19 2016, 9:36 PM
f2d1dad786c3	52f43a5fbd16	14151a1e8563	Sebastian Kügler	update modelist on RRNotify events	Oct 19 2016, 9:27 PM
14151a1e8563	c218b74180dd	7d346d2f77ae	Sebastian Kügler	improve test a little	Oct 19 2016, 3:31 AM
7d346d2f77ae	f893b62db6b3	219354d7cae0	Sebastian Kügler	autotest for modelist changes	Oct 19 2016, 3:20 AM
219354d7cae0	7b8d419ed817	d8ae0a243e28	Sebastian Kügler	allow changing an output's modelist at runtime (Show More…)	Oct 19 2016, 3:19 AM