[shell] Create panelshadow in surfacecreated event instead of show event
ClosedPublic
Actions

Authored by graesslin on Oct 19 2016, 8:37 AM.

Details

Reviewers

mart
broulik

Group Reviewers

Plasma

Commits

Summary

In the show event the Wayland implementation does not pick up the shadow
at all.

BUG: 368885

Test Plan

Shadow on Wayland, not tested on X11

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin retitled this revision from to [shell] Create panelshadow in surfacecreated event instead of show event.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: Plasma, mart.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Works on X11 as well.

plasma-frameworks dialog probably also needs this treatment (also does it in showEvent)

This revision is now accepted and ready to land.Oct 19 2016, 9:07 AM

In D3109#57649, @broulik wrote:

Works on X11 as well.

plasma-frameworks dialog probably also needs this treatment (also does it in showEvent)

for whatever reason it works with dialogs *shrug*

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			shell/panelview.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7536	d0df572		Oct 19 2016, 8:37 AM	★	★
Diff 2	7542	453ae78	rPLASMAWORKSPACE59733c21a4bb0d04bb76367995aa611e66f5f3e5	Oct 19 2016, 11:04 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
72c376442443	45f1d183eb36	d0df5725d9ca	Martin Gräßlin	[shell] Create panelshadow in surfacecreated event instead of show event (Show More…)	Oct 19 2016, 8:35 AM