Differential D3104

Fix indenter issues for cstyle and cppstyle (DUPLICATE)
AbandonedPublic
Actions

Authored by bevendorff on Oct 18 2016, 8:22 PM.

Details

Reviewers
brauch
Summary

The cstyle and cppstyle indenter had certain issues with auto brackets (wrong indentation and semicolons inserted instead of closing braces). This patch fixes those issues and adds unit tests for the new behavior.
See https://bugs.kde.org/show_bug.cgi?id=370715 for more information.

EDIT:
Due to arc being weird, this is a duplicate and can be closed. The new revision can be found here: https://phabricator.kde.org/D3105

Diff Detail

Repository
R39 KTextEditor
Lint
Lint Skipped
Unit
Unit Tests Skipped
bevendorff updated this revision to Diff 7518.Oct 18 2016, 8:22 PM
bevendorff retitled this revision from to Fix indenter issues for cstyle and cppstyle.
bevendorff updated this object.
bevendorff edited the test plan for this revision. (Show Details)
bevendorff added a reviewer: brauch.
bevendorff set the repository for this revision to R39 KTextEditor.
bevendorff added a project: KTextEditor.
Restricted Application added a subscriber: kwrite-devel. · View Herald TranscriptOct 18 2016, 8:22 PM
bevendorff updated this revision to Diff 7519.Oct 18 2016, 8:28 PM

Hmm. Somehow Phabricator only accepts the first file. The patch contains changes in many files, though. How do I submit the full patch here?

kfunk added a subscriber: kfunk.Oct 18 2016, 8:31 PM
In D3104#57538, @bevendorff wrote:

Hmm. Somehow Phabricator only accepts the first file. The patch contains changes in many files, though. How do I submit the full patch here?

Did you try arc from the command-line? See https://community.kde.org/Infrastructure/Phabricator#Posting_Patches.

bevendorff added a comment.Oct 18 2016, 8:33 PM

Did you try arc from the command-line? See https://community.kde.org/Infrastructure/Phabricator#Posting_Patches.

Well, no. I tried building it from AUR, but the package was broken. However, seems to be fixed now. Trying…

bevendorff added a comment.Oct 18 2016, 8:38 PM

Alright, seems to work. It created a new revision, though: https://phabricator.kde.org/D3105
I guess this one can be discarded then.

bevendorff retitled this revision from Fix indenter issues for cstyle and cppstyle to Fix indenter issues for cstyle and cppstyle (DUPLICATE).Oct 18 2016, 8:46 PM
bevendorff updated this object.
nalvarez added a subscriber: nalvarez.Oct 18 2016, 9:05 PM

As the submitter, you can discard the review yourself. For someone else to do it it's more steps :)

bevendorff abandoned this revision.Oct 18 2016, 9:15 PM

Ah, okay. Not very discoverable that feature. Had to search quite a bit.

Revision Contents
Changeset List

Diff 7519

View Options

src/script/data/indentation/cstyle.js

Loading...