Changed the launcher modification API
ClosedPublic

Authored by ivan on Oct 18 2016, 10:02 AM.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ivan updated this revision to Diff 7502.Oct 18 2016, 10:02 AM
ivan retitled this revision from to Changed the launcher modification API.
ivan updated this object.
ivan edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptOct 18 2016, 10:02 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ivan updated this revision to Diff 7505.Oct 18 2016, 10:48 AM
  • When all activities are selected, select the 'All activities' item
mart added a subscriber: mart.Oct 18 2016, 4:14 PM

+1

shouldn't cause problems changing api of libtaskmanager btw? (here compatibility is not guaranteed)

hein accepted this revision.Oct 18 2016, 6:33 PM
hein edited edge metadata.
This revision is now accepted and ready to land.Oct 18 2016, 6:33 PM
ivan added a comment.Oct 18 2016, 10:09 PM

shouldn't cause problems changing api of libtaskmanager btw?

This is changing API that I added in the patch (not released API) - not sure why arc made the last commit message to be the main one :)

This revision was automatically updated to reflect the committed changes.
mart added a comment.Oct 21 2016, 8:56 AM

ah, can you bump the soversion of libtaskmanager while you're at?

hein added a comment.Oct 21 2016, 9:12 AM

We've never done this before though. libtaskmanager isn't public API and we make no stability guarantees for it at all. I mean, not that bumping hurts.

ivan added a comment.Oct 22 2016, 9:32 AM

Just to reiterate - there should be no ABI incompatibilities compared to the previous version of the library. The API I changed was never in master (and thus never released).