Implement cursor shape tracking on Wayland
ClosedPublic

Authored by graesslin on Oct 18 2016, 7:49 AM.

Details

Summary

So far the tracking for cursor shape was done incorrectly on Wayland by
only listening to X11 cursor changes. That's from a time when
KWin/Wayland was still run on top of an X server.

Nowadays the Platform tracks cursor shape changes and emits changes to
it. Xwayland cursor changes go through the normal Wayland way so it's
just one way to get it on Wayland.

This change adds the required connect and changes the signal signature
in Cursor by dropping the serial argument. No user of the signal uses
the argument and on Wayland we don't have a serial for the cursor. So it
can be dropped.

Test Plan

Zoom effect updates cursor shape correctly on Wayland

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7499.Oct 18 2016, 7:49 AM
graesslin retitled this revision from to Implement cursor shape tracking on Wayland.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptOct 18 2016, 7:49 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Oct 19 2016, 2:38 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Oct 19 2016, 2:38 PM
This revision was automatically updated to reflect the committed changes.