Differential D3084

[shell] Support autohide panel on wayland
ClosedPublic
Actions

Authored by bshah on Oct 17 2016, 1:20 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R871:d0df5725d9ca: [shell] Support autohide panel on wayland
R120:d0df5725d9ca: [shell] Support autohide panel on wayland
Summary

This makes use of requests to hide and show autohide panels from
kwayland

Depends on D3007

Test Plan

autohide panel now works, with D3080 in kwin, but windows can
cover panel still needs work

Diff Detail

Repository
R120 Plasma Workspace
Branch
panel-autohide
Lint
No Linters Available
Unit
No Unit Test Coverage
bshah updated this revision to Diff 7458.Oct 17 2016, 1:20 PM
bshah retitled this revision from to [shell] Support autohide panel on wayland.
bshah updated this object.
bshah edited the test plan for this revision. (Show Details)
bshah added reviewers: Plasma, graesslin.
bshah added a dependency: D3007: Add auto-hiding panel support to PlasmaShellSurface interface.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 17 2016, 1:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah updated this revision to Diff 7459.Oct 17 2016, 1:22 PM

update commit message

bshah updated this revision to Diff 7460.Oct 17 2016, 1:25 PM
bshah edited the test plan for this revision. (Show Details)

edit message for real

graesslin edited edge metadata.Oct 17 2016, 2:53 PM

Wayland side looks good to me.

shell/panelview.cpp
651 ↗(On Diff #7458)

do we also need to request the slide for the panel on WAyland?

bshah marked an inline comment as done.Oct 17 2016, 3:04 PM
bshah added inline comments.
shell/panelview.cpp
651 ↗(On Diff #7458)

I don't think so.. because from my testing panel sliding seems to work normally.

graesslin accepted this revision.Oct 18 2016, 5:43 AM
graesslin edited edge metadata.
This revision is now accepted and ready to land.Oct 18 2016, 5:43 AM
graesslin added a comment.Oct 18 2016, 6:21 AM

When pushing please add bug 369386

Closed by commit R120:d0df5725d9ca: [shell] Support autohide panel on wayland (authored by bshah). · Explain WhyOct 18 2016, 6:55 AM
This revision was automatically updated to reflect the committed changes.
bshah marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
Mshell/panelview.cpp (7 lines)

Diff 7459

View Options

shell/panelview.cpp

Loading...