The Dashboard needs to connect to the new toggled signal chain, because this is now instead called by KWin.
Dependent on this diff in plasma-framework: https://git.reviewboard.kde.org/r/129204/
A more extensive description of the problem and the proposed solution can be found there.
| Lint Skipped |
| Unit Tests Skipped |
This breaks the normal keyboard shortcut working at all.
You either need to connect to both or
if we put in the addition emit I suggest in https://git.reviewboard.kde.org/r/129204/
and then you don't need this change.
Does it not work on your system? Have you also applied the other diffs on phab mentioned in the reviewboard diff? It shouldn't break the normal keyboard shortcut. It works on my system.
EDIT: Ah yes, only in the Dashboard case! Thanks, I'll look into it.
Adjustements to second revision of the Diff in Plasma-Frameworks on Reviewboard: https://git.reviewboard.kde.org/r/129204/
| applets/kicker/package/contents/ui/main.qml | ||
|---|---|---|
| 47 | If you want this to be in Plasma/5.8.x we can't rely on this being available. Plasma 5.8.x *has* to still work with frameworks 5.26. You can either go master only or do the following: Component.onCompleted: { shrinkOnReactivation = !isDash } | |