Remove setting of QT_XCB_NO_EVENT_COMPRESSION env var
ClosedPublic

Authored by gladhorn on Oct 15 2016, 8:36 PM.

Details

Summary

See https://bugreports.qt.io/browse/QTBUG-44964:
The patch that went into Qt 5.6.1 is:
https://codereview.qt-project.org/#/c/157348/
which simply disables compression.

https://codereview.qt-project.org/#/c/156755/ was abandoned, so this
variable never had any effect.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gladhorn updated this revision to Diff 7408.Oct 15 2016, 8:36 PM
gladhorn retitled this revision from to Remove setting of QT_XCB_NO_EVENT_COMPRESSION env var.
gladhorn updated this object.
gladhorn edited the test plan for this revision. (Show Details)
rempt accepted this revision.Oct 18 2016, 7:05 AM
rempt added a reviewer: rempt.
rempt added a subscriber: rempt.

Yes, it should be safe to push this. We use Qt 5.6.1 for our own builds now, so we should be safe. I should check whether the patch to disable event compression is still used, too... And update to 5.6.2, I guess!

This revision is now accepted and ready to land.Oct 18 2016, 7:05 AM
This revision was automatically updated to reflect the committed changes.
timotheegiet added a subscriber: timotheegiet.EditedOct 18 2016, 11:26 AM

Just a note for last comment from boud:

As I commented on https://bugreports.qt.io/browse/QTBUG-44964 , when I used 5.6.1 to build, I still had event compression issues with the tablet.
Still had to disable event compression completely with krita's patch to have smooth tablet strokes on this system.

Now I'm building with 5.7.0, still with krita's patch but again customized for new Qt version.
I guess we'll need to add something in krita's code to adapt it to https://codereview.qt-project.org/#/c/157011/ ?

Indeed, looks like Krita should add qApp->setAttribute(Qt::AA_CompressHighFrequencyEvents, false);
Note that the old code wouldn't have helped - it was effectively dead code.

rempt added a comment.EditedOct 19 2016, 9:39 AM

I've added that attribute, conditional on Qt 5.7 being used. We're not building appimages with Qt 5.7 yet (there were some bug reports about focus issues that we need to investigate), so I'll keep the patch around for now.