[effects] Delay taking screenshot into next rendering cycle
ClosedPublic

Authored by graesslin on Oct 14 2016, 9:38 AM.

Details

Summary

For windows the screenshot effect already delayed the rendering into the
next cycle. But for the fullscreen variants which save to a file the
Screenshot effect did try to take the shot directly.

This can be problematic as e.g. the OpenGL context might not be bound at
all. Also this makes it impossible to screenshot multiple screens
together in the Wayland case.

This change delays the DBus replies, schedules the geometry and takes
the screenshot in the next rendering pass. It does not fix the
multiscreen wayland problem yet.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7385.Oct 14 2016, 9:38 AM
graesslin retitled this revision from to [effects] Delay taking screenshot into next rendering cycle.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: KWin.
Restricted Application added a project: KWin. · View Herald TranscriptOct 14 2016, 9:38 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson accepted this revision.Oct 14 2016, 9:48 AM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Oct 14 2016, 9:48 AM
This revision was automatically updated to reflect the committed changes.