Differential D3048

[Colors KCM] Default scheme is now installed as a file
AbandonedPublic
Actions

Authored by ochurlaud on Oct 13 2016, 9:39 AM.

Details

Reviewers
mart
broulik
Group Reviewers
Plasma
Summary

The default values are not anymore taken from the hardcoded ones in kconfigwidget.

BUG: 370305

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
ochurlaud updated this revision to Diff 7373.Oct 13 2016, 9:39 AM
ochurlaud retitled this revision from to [Colors KCM] Default scheme is now installed as a file.
ochurlaud updated this object.
ochurlaud edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptOct 13 2016, 9:39 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ochurlaud added reviewers: Plasma, mart, broulik.Oct 13 2016, 9:40 AM

One draw back of this way is that if Default.colors is erased or not found, there is no "Default", and in case no *.colors are found, the kcm will be empty...

mart edited edge metadata.Oct 13 2016, 9:49 AM

hmm, also wouldn't be loaded if a kde app is loaded from another desktopwithout config prior existing i guess

kcms/colors/colorscm.cpp
118

is this name localized?

mart added a comment.Oct 13 2016, 11:25 AM

i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in kconfigwidget itself

ochurlaud added a comment.Oct 13 2016, 11:45 AM
In D3048#56488, @mart wrote:

i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in kconfigwidget itself

Then I need help :)

kcms/colors/colorscm.cpp
118

No, it's not. But next line should be:

new QListWidgetItem(icon, i18nc("Default color scheme", "Default"));

mart added a comment.Oct 13 2016, 12:00 PM
In D3048#56489, @ochurlaud wrote:
In D3048#56488, @mart wrote:

i am in favor of this chane, but i think the real reson of the breakage should be investigated as well, uf there may be problems in kconfigwidget itself

Then I need help :)

ok, later today i'll give a try at that bug hunting as well.
depending from the result, we'll see what to do about this one, ok?

ochurlaud abandoned this revision.Oct 14 2016, 11:55 AM

Revision Contents
Changeset List

Diff 7373

View Options

kcms/colors/colorscm.cpp

Loading...
View Options

kcms/colors/schemes/Default.colors

Loading...
View Options

kcms/colors/scmeditordialog.cpp

Loading...