Setting a window property on a platform handle passes it to the
QtExtendedSurface interface and that way to the compositor.
Details
Details
- Reviewers
sebas - Group Reviewers
Plasma - Commits
- R135:f8a0f8c0c82e: Pass color scheme hint to Wayland compositor using window property
Diff Detail
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
In line 57 QCoreApplication -> QGuiApplication
| src/platformtheme/kwaylandintegration.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #7369) | QCoreApplication -> QGuiApplication |
| src/platformtheme/kwaylandintegration.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #7369) | this is completely unrelated code not touched in this change. |
| src/platformtheme/kwaylandintegration.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #7369) | #include <QCoreApplication> removed and #include <QGuiApplication added so isn't this also should be change ? |
| src/platformtheme/kwaylandintegration.cpp | ||
|---|---|---|
| 57 ↗ | (On Diff #7369) | no? We try to not change unrelated code. The include of QGuiApplication is due to the usage of QGuiApplication::topLevelWindows. For this code it doesn't make any difference whether it's QCoreApplication or QGuiApplication. So there is no need to change it. The code is correct and a change would clutter up the commit. |