Support docks which take input
ClosedPublic

Authored by graesslin on Oct 12 2016, 1:13 PM.

Details

Summary

On X11 one needs to force activate a panel to pass it focus. This change
implements something similar for Wayland but a little bit more stateful
by using a request on the PlasmaShellSurface. If set KWin will activate
the panel.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7346.Oct 12 2016, 1:13 PM
graesslin retitled this revision from to Support docks which take input.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptOct 12 2016, 1:13 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

Errrr... this does not allow the dock to control input, ie. the dock can or can not take focus but you want focus if eg. clicking into a lineedit while do certainly not want it when clicking a button that will activate a window (FSP trouble)

With the stateful approach, the dock would have to juggle around the setting instead of just telling the WM to pass it the focus *now* (for some local user interaction)

Errrr... this does not allow the dock to control input, ie. the dock can or can not take focus but you want focus if eg. clicking into a lineedit while do certainly not want it when clicking a button that will activate a window (FSP trouble)

With the stateful approach, the dock would have to juggle around the setting instead of just telling the WM to pass it the focus *now* (for some local user interaction)

I don't see any real world cases where that would be needed. In Plasma we either have a panel with no input fields at all (normal panel) or panels which should have focus directly from start (e.g. widget explorer). They have an input field but typing in it should start searching directly, if not the input is delegated to krunner, which is certainly not what is wanted.

sebas accepted this revision.Oct 16 2016, 2:50 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Oct 16 2016, 2:50 PM

I don't see any real world cases where that would be needed.

Embedded runners/search widgets (pretty famous item on KDE3 times, no idea whether it's relevant)

"You have been warned" :-P

This revision was automatically updated to reflect the committed changes.