Lockscreen: New session only on switchSessionPage

Authored by romangg on Oct 12 2016, 11:41 AM.



Andreas brought up this idea in the VDG Telegram group earlier today.

The lockscreen's functionality is in the first place to lock the screen and therefore it shouldn't largely advertise the possibility of switching the session.

That's why we should move the switching functionality including the creation of a new session completely to the subpage switchSessionPage.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
romangg updated this revision to Diff 7341.Oct 12 2016, 11:41 AM
romangg retitled this revision from to Lockscreen: New session only on switchSessionPage.
romangg updated this object.
romangg edited the test plan for this revision. (Show Details)
romangg added a reviewer: davidedmundson.
romangg set the repository for this revision to R120 Plasma Workspace.
romangg added a project: VDG.
romangg added a subscriber: andreask.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 12 2016, 11:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Makes sense to me, but can you check that all the VDG involved in the lock screen support this as it's a deviation from the design.

Also please clean up newSession signal in MainBlock.qml

romangg updated this revision to Diff 7349.Oct 12 2016, 3:29 PM
romangg edited edge metadata.
romangg added a subscriber: colomar.
  • Cleanup of newSession signal
  • Text on button on switch user page now changes accordingly to action

Regarding the VDG: There wasn't a decision until now. But from my point of view it's as follows:
The original mockup wasn't fully realized in this regard anyway (the idea was to show all sessions on only one page). So there is already a significant deviation from the design. We shouldn't present the "New session" option in the main lockscreen while not presenting other sessions, nor does it make sense to have this option duplicated on both pages. It's therefore better (regarding the initial deviation) to put the "New session" only in the second page and having all possible actions regarding the creation or switching to other sessions concentrated here.

But maybe Andreas or Thomas can chime in.

romangg updated this object.Oct 12 2016, 3:44 PM
romangg updated this object.Oct 12 2016, 3:48 PM

Code is now fine, thanks.

(btw if you do any other changes here, you should probably know about
/usr/lib64/libexec/kscreenlocker_greet --testing - especially if you're taking screenshots)

So there is already a significant deviation from the design.

No there isn't.

FWIW, here is the original design.

It lists New Session and there is a button at the bottom for switching to existing sessions.

It's fine for it to change, and I'm personally for the change - but if we have a design I don't want to just ignore it.

romangg added a comment.EditedOct 12 2016, 4:14 PM

but if we have a design I don't want to just ignore it.

Absolutely! I just didn't know about this mockup. Thanks for the link. I was looking at the task right here before: https://phabricator.kde.org/T3364

EDIT: Ok, i just realize there is a small link to the mockup in between the comments. Sorry for not seeing the link earlier.

davidedmundson accepted this revision.Oct 13 2016, 11:54 AM
davidedmundson edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2016, 11:54 AM
This revision was automatically updated to reflect the committed changes.