diff --git a/krusader/Panel/listpanel.cpp b/krusader/Panel/listpanel.cpp --- a/krusader/Panel/listpanel.cpp +++ b/krusader/Panel/listpanel.cpp @@ -1029,6 +1029,8 @@ void ListPanel::panelInactive() { // don't refresh when not active (ie: hidden, application isn't focused ...) + // TODO disabled so that the user sees changes in non-focused window; if the performance impact + // is too high we need another solution here //func->files()->vfs_enableRefresh(false); } diff --git a/krusader/Panel/panelfunc.cpp b/krusader/Panel/panelfunc.cpp --- a/krusader/Panel/panelfunc.cpp +++ b/krusader/Panel/panelfunc.cpp @@ -703,6 +703,7 @@ } // for } +// TODO it is not possible to move virtual local files to trash void ListPanelFunc::deleteFiles(bool reallyDelete) { // first get the selected file names list diff --git a/krusader/VFS/vfile.cpp b/krusader/VFS/vfile.cpp --- a/krusader/VFS/vfile.cpp +++ b/krusader/VFS/vfile.cpp @@ -42,6 +42,8 @@ bool vfile::vfile_userDefinedFolderIcons = true; +// TODO set default vfile_size to '-1' to distinguish between empty directories and directories with +// unknown size vfile::vfile(const QString& name, // useful construtor const KIO::filesize_t size, diff --git a/krusader/VFS/vfs.h b/krusader/VFS/vfs.h --- a/krusader/VFS/vfs.h +++ b/krusader/VFS/vfs.h @@ -117,6 +117,7 @@ /// Return a list of vfiles for a search query. Or an empty list if nothing was found. QList searchVfiles(const KRQuery &filter); /// The total size of all files in the current directory (only valid after refresh). + // TODO unused KIO::filesize_t vfs_totalSize(); /// Return the VFS type. inline VFS_TYPE type() { return _type; } @@ -151,6 +152,7 @@ public slots: /// Re-read the current directory files or change to another directory. Blocking. /// If the directory was read true is returned else false. + // optional TODO: add an async version of this bool refresh(const QUrl &directory = QUrl()); /// Notify this VFS that the current directory content may have changed. void mayRefresh(); diff --git a/krusader/VFS/vfs.cpp b/krusader/VFS/vfs.cpp --- a/krusader/VFS/vfs.cpp +++ b/krusader/VFS/vfs.cpp @@ -115,6 +115,7 @@ return adjustedUrl; } +// TODO (re-)implement incremental refresh bool vfs::refresh(const QUrl &directory) { @@ -226,10 +227,10 @@ } } +// TODO called from another thread, creating KIO jobs does not work here void vfs::calcSpaceKIO(const QUrl &url, KIO::filesize_t *totalSize, unsigned long *totalFiles, unsigned long *totalDirs, bool *stop) { - // TODO does not work return; if (stop && *stop) diff --git a/krusader/VFS/virt_vfs.cpp b/krusader/VFS/virt_vfs.cpp --- a/krusader/VFS/virt_vfs.cpp +++ b/krusader/VFS/virt_vfs.cpp @@ -348,6 +348,7 @@ } if (!_fileEntry.contains(KIO::UDSEntry::UDS_MODIFICATION_TIME)) { + // TODO this also happens for FTP directories return 0; // file not found }