Differential D3023

Set icon to wayland if desktop file is not found
ClosedPublic
Actions

Authored by graesslin on Oct 11 2016, 2:36 PM.

Details

Reviewers
sebas
Group Reviewers
Plasma on Wayland
KWin
Commits
R108:8201def97fcc: Set icon to wayland if desktop file is not found
Summary

For X windows KWin uses the generic X icon if no icon is found. Thus
KWin should use the generic Wayland icon if no icon is found for a
Wayland client.

With this change applications with incorrect desktop file name at least
get a generic icon instead of no icon.

Test Plan

Started Qt assistant on Wayland and it had icon.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7308.Oct 11 2016, 2:36 PM
graesslin retitled this revision from to Set icon to wayland if desktop file is not found.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptOct 11 2016, 2:36 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Oct 16 2016, 2:41 PM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

Looks good.

This revision is now accepted and ready to land.Oct 16 2016, 2:41 PM
Closed by commit R108:8201def97fcc: Set icon to wayland if desktop file is not found (authored by graesslin). · Explain WhyOct 17 2016, 7:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell_client.cpp (6 lines)

Diff 7444

View Options

shell_client.cpp

Loading...