Fix shortcut triggering with shift+letter
ClosedPublic

Authored by graesslin on Oct 11 2016, 7:51 AM.

Details

Summary

A shortcut with e.g. shift+w could not be triggered as shift is
considered as consumed. It transforms the keysym to an uppercase variant
thus it is consumed.

This change checks for the condition that shift is pressed and is the
only consumed modifier. If the current keysym is a letter the shift is
removed from the consumed modifier again to still support the shortcut.

BUG: 370341
FIXED-IN: 5.8.2

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7293.Oct 11 2016, 7:51 AM
graesslin retitled this revision from to Fix shortcut triggering with shift+letter.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptOct 11 2016, 7:51 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
sebas accepted this revision.Oct 16 2016, 2:35 PM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

Makes sense.

This revision is now accepted and ready to land.Oct 16 2016, 2:35 PM
This revision was automatically updated to reflect the committed changes.