We do the same on the lock screen and the code is straight from there.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma: Design Plasma - Commits
- R120:4d0a0a453dbb: [SDDM Theme] Show caps lock warning
R871:4d0a0a453dbb: [SDDM Theme] Show caps lock warning
Tested in both qmlscene and with a new sddm session
Capslock enabled: "Caps lock is on"
Capslock enabled with unlocking failed "Caps lock is in – login failed"
capslock not enabled with unlocking failed: "login failed"
This could even be put in 5.8 as the string is already there (as you can see it's translated for me already)
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
+1 for the change!
I think the string for failed unlock while capslock is on should be "Login failed (Caps lock is on)" though, as the "login failed" part is the more important one.
Comment Actions
I just made it consistent with what we have in the lock screen and with what we have had for years.
We could surely change that (the bullet isn't translated anyway) but if we were to do this it must be consistently done in both places.