Add auto-hiding panel support to PlasmaShellSurface interface
ClosedPublic

Authored by graesslin on Oct 10 2016, 2:44 PM.

Details

Summary

This change adds support for auto-hiding panels. A PlasmaShellSurface
with Role Panel and PanelBehavior AutoHide can request to get
auto-hidden at a screen edge. The compositor will then not show the
surface although it is still mapped and will show it again once the
screen edge gets triggered.

The interface is extended by one new request to allow the client to
request the hiding of the surface. In addition two events are added to
inform the client when the surface got hidden and when it got shown
again.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7264.Oct 10 2016, 2:44 PM
graesslin retitled this revision from to Add auto-hiding panel support to PlasmaShellSurface interface.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma on Wayland.
Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptOct 10 2016, 2:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Oct 10 2016, 4:10 PM
sebas added a reviewer: sebas.
sebas added a subscriber: sebas.

a few docs improvements proposed, otherwise, it looks clean, clear and simple.

src/client/plasmashell.h
293

Behavior (typo)

306

past tense of hide is "hid"

314

"showed" is a bit ambiguous here, as that *could* mean it's not shown anymore. Maybe just make it clear that the signal is emitted after the show panel animation is finished?

src/client/protocols/plasma-shell.xml
350

screen edge *or* panel borders

351

visibility*,*

This revision is now accepted and ready to land.Oct 10 2016, 4:10 PM
graesslin updated this revision to Diff 7335.Oct 12 2016, 6:48 AM
graesslin edited edge metadata.

Added a request to show the auto-hidden panel from client side

This revision was automatically updated to reflect the committed changes.