Differential D2995

No-op SeachRunner if indexing is disabled
ClosedPublic
Actions

Authored by davidedmundson on Oct 10 2016, 12:36 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R120:6396bcd1243b: No-op SeachRunner if indexing is disabled
R871:6396bcd1243b: No-op SeachRunner if indexing is disabled
Summary

We won't have any results anyway.

Test Plan

Disabled indexing and put a qDebug in the if branch

I'm not super convinced it's a good idea myself. It means parsing a config file every match
and it can't be cached without missing updates if the user enables/disables at runtime.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 7238.Oct 10 2016, 12:36 AM
davidedmundson retitled this revision from to No-op SeachRunner if indexing is disabled.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 10 2016, 12:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
Closed by commit R120:6396bcd1243b: No-op SeachRunner if indexing is disabled (authored by davidedmundson). · Explain WhyOct 10 2016, 10:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7252

View Options

runners/baloo/baloosearchrunner.cpp

Loading...