ScreenPool: Store primary connector separately
AbandonedPublic
Actions

Authored by genpfault on Oct 3 2020, 3:12 AM.

Details

Summary

Store the primary connector in a dedicated config key instead of making slot 0 do double-duty. This prevents setPrimaryConnector() from renumbering the connector list and 'losing' existing panel/desktop settings.
Add a helper function to generate connector names instead of using QScreen::name() everywhere. The helper function defaults to a QScreen::manufacturer()/model()/serialNumber() tuple where available with a fall-back to the original name() logic.

Repository

R120 Plasma Workspace

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

genpfault requested review of this revision.Oct 3 2020, 3:12 AM

Thanks for the patch, however we use GitLab now for contributing code.

			Path	Packages
M			shell/autotests/screenpooltest.cpp (45 lines)
M			shell/screenpool.h (5 lines)
M			shell/screenpool.cpp (55 lines)
M			shell/shellcorona.cpp (28 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	83368			Oct 3 2020, 3:01 AM	★	★