Differential D29873

Close windows when saving session data
AbandonedPublic
Actions

Authored by xyquadrat on Aug 2 2020, 10:56 AM.

Details

Reviewers
kossebau
wbauer
carewolf
Summary

After a bug fix in Qt 5.14 we now get real close events for unclosed windows when
the application closes, so we would be getting two close events breaking our
logic when when to suppress on-close dialogs.

BUG: 416728

Diff Detail

Branch
fix-close (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27180
Build 27198: arc lint + arc unit
carewolf requested review of this revision.Aug 2 2020, 10:56 AM
carewolf created this revision.
carewolf edited the summary of this revision. (Show Details)Aug 2 2020, 10:59 AM
carewolf added a reviewer: kossebau.
ngraham added a subscriber: ngraham.Aug 2 2020, 12:47 PM

We've moved to GitLab; would you mind re-submitting this as a merge request over at https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/?

Relevant documentation is at https://community.kde.org/Infrastructure/GitLab.

Thanks!

xyquadrat commandeered this revision.Aug 6 2020, 3:21 PM
xyquadrat added a reviewer: carewolf.
xyquadrat added a subscriber: xyquadrat.

Was moved to https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/10, closing this revision here.

xyquadrat abandoned this revision.Aug 6 2020, 3:21 PM

Revision Contents
Changeset List

PathPackages
Msrc/kmainwindow.cpp (13 lines)

Diff 83336

View Options

src/kmainwindow.cpp

Loading...