Differential D29857

Fix: kwalletmanager cannot be started by systemsettings/account details/launch
ClosedPublic
Actions

Authored by ZaWertun on Jun 18 2020, 12:59 PM.

Details

Reviewers
cfeck
davidedmundson
Summary

This commit fixes bug https://bugs.kde.org/show_bug.cgi?id=421178.
After this commit you'll able to launch kwalletmanager5 after clicking button "Launch Wallet Manager" from the kwalletconfig5.

Test Plan
  1. Start "kcmshell5 kwalletconfig5";
  2. Click "Launch Wallet Manager";
  3. Wallet Manager will be started.

Diff Detail

Repository
R362 KWalletManager
Lint
Lint Skipped
Unit
Unit Tests Skipped
ZaWertun created this revision.Jun 18 2020, 12:59 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJun 18 2020, 12:59 PM
ZaWertun requested review of this revision.Jun 18 2020, 12:59 PM
ZaWertun retitled this revision from kwalletconfig5 tries to start process named "kwalletmanager5 --show" to Fix: kwalletmanager cannot be started by systemsettings/account details/launch.
ZaWertun edited reviewers, added: cfeck; removed: davidedmundson.Jun 19 2020, 8:41 AM
davidedmundson accepted this revision.Jun 19 2020, 8:43 AM
davidedmundson added a subscriber: davidedmundson.

Ideally this should be ApplicationLaunchJob, but that can be another patch.

Patch won't apply directly, but you've done the work finding the bug, I can sort that.

This revision is now accepted and ready to land.Jun 19 2020, 8:43 AM
ZaWertun added a comment.Jun 19 2020, 8:44 AM

Patch won't apply directly, but you've done the work finding the bug, I can sort that.

Wrong top dir?

pino closed this revision.Jun 19 2020, 8:56 AM
pino added a subscriber: pino.

Patch won't apply directly, but you've done the work finding the bug, I can sort that.

That's because I already fixed it:
https://commits.kde.org/kwalletmanager/9cf4ab73cd9b6eb38ddf8f55dca797510de513f0
Hence closing this revision.

Thanks anyway for the patch.

Revision Contents
Changeset List

Diff 83292

View Options

kwalletmanager-20.04.2/src/konfigurator/konfigurator.cpp

Loading...