Differential D29822

Signal the main window about vnc disconnection
ClosedPublic
Actions

Authored by yuyichao on May 20 2020, 5:04 AM.

Details

Reviewers
davidedmundson
uwolfer
ahmadsamir
murrant
cfeck
Summary

When the client is quitted and have stopped trying to reconnect.

Previously, a failed connection will leave the main window in a "connected" state
and require manually pressing the "Disconnect" button before a new connection can be made.

Use of the disconnected signal copied from the RDP backend, which handles this correctly.

Test Plan

Tested behavior on 20.04 branch. Tested compilation also on master.

Diff Detail

Repository
R436 KRDC
Branch
vnc-quit (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27037
Build 27055: arc lint + arc unit
yuyichao requested review of this revision.May 20 2020, 5:04 AM
yuyichao created this revision.
yuyichao updated this revision to Diff 83081.May 20 2020, 5:38 AM

Include more disconnection cases than the ones from the vnc library.

yuyichao updated this revision to Diff 83082.May 20 2020, 5:41 AM

Add comment about preserving error messages for the user.

uwolfer added inline comments.May 25 2020, 6:09 PM
vnc/vncview.cpp
208

this signal was never emitted before in this class, right? are you sure you need to emit this manually?

219

is this required? m_quitFlag is initialized with false at the top (m_quitFlag(false),).

yuyichao marked 2 inline comments as done.May 25 2020, 8:12 PM
yuyichao added inline comments.
vnc/vncview.cpp
208

Yes, this must be emitted manually and all other backends (rdp and the unfunctional nx) does this. This never done in this class is exactly the cause for the bug I mentioned in the description.

219

See the comment I added for this. I can also make this an assert.

yuyichao marked 2 inline comments as done.Jun 8 2020, 1:05 PM

Ping?

uwolfer accepted this revision.Jun 10 2020, 7:22 PM

Code looks good to me - but I've not tested this change.

This revision is now accepted and ready to land.Jun 10 2020, 7:22 PM
yuyichao closed this revision.Jun 13 2020, 1:46 PM

Revision Contents
Changeset List

PathPackages
Mvnc/vncview.cpp (11 lines)

Diff 83081

View Options

vnc/vncview.cpp

Loading...