Correction when displaying "badger counter" icons using software rendering
AbandonedPublic
Actions

Authored by ngraham on May 19 2020, 11:45 AM.

Details

Reviewers

Summary

Icons that use content overlay, leave the icon hidden when using software rendering.

This small change corrects the problem and I did not notice any problems as a result.

A simple test for this is to use the desktop telegram with the plasma in software rendering and taskbar in icon-only mode.

Using OpenGL the icon is displayed and a counter with the number of messages appears overlapping part of the icon, all right.

Using software rendering, the icon disappears when the counter is displayed.

With this modification, the operation using software rendering is corrected.

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

We have moved to GitLab now; could you submit this as a Merge Request at https://invent.kde.org/plasma/plasma-desktop/-/merge_requests?

Thanks!

yes please on gitlab.
are you sure you don't get double painting on opengl now?

applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml
47	does this still renders correctly when used on hardware rendering? i suspect the cut away effect won't be visible?

This was done on GitLab, and was gated on hardware rendering being used.

			Path	Packages
M			applets/taskmanager/package/contents/ui/TaskBadgeOverlay.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	83061			May 19 2020, 11:38 AM	★	★