Differential D29816

Fix chained operations involving inserted numbers
AbandonedPublic
Actions

Authored by ovp on May 18 2020, 3:17 PM.

Details

Reviewers
None
Summary

BUG: 412401
FIXED-IN: 20.04.2

This is a quick and dirty fix which only adds to the technical debt
(which in this case is better than nothing). A proper fix requires code
refactoring (mainly targeted at improving separation of concerns and
logic deduplication) and adding unit tests at least for this
particular case.

Diff Detail

Repository
R353 KCalc
Branch
fix-chained-operations (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27017
Build 27035: arc lint + arc unit
ovp created this revision.May 18 2020, 3:17 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptMay 18 2020, 3:17 PM
ovp requested review of this revision.May 18 2020, 3:17 PM
ovp updated this revision to Diff 83045.May 18 2020, 3:30 PM
  • Fix KCalculator::slotPaste documentation
ovp abandoned this revision.May 20 2020, 8:36 PM

Ok, it seems like I have chosen a bad time for submitting the fix. Please, disregard this review request and check the merge request on Gitlab.

ovp removed a reviewer: mlaurent.May 20 2020, 8:37 PM

Revision Contents
Changeset List

PathPackages
Mkcalc.h (2 lines)
Mkcalc.cpp (13 lines)

Diff 83045

View Options

kcalc.h

Loading...
View Options

kcalc.cpp

Loading...