Move the DrKonqi socket name generation out of the signal handler, since it can freeze while locking QTextCodec mutexes
Signed-off-by: Jiří Paleček <jpalecek@web.de>
dfaure |
Frameworks |
Move the DrKonqi socket name generation out of the signal handler, since it can freeze while locking QTextCodec mutexes
Signed-off-by: Jiří Paleček <jpalecek@web.de>
Lint OK |
No Unit Test Coverage |
The changes you mention don't appear in phabricator.
I suggest amending your commit locally (so there's only one) and then
arc diff HEAD~
Just to clarify. I of course have it as one commit locally, but I have them more on a branch and develop and test them together. So when I was amending the individual commits I made an error in distributing the changes.
Then I don't use arc because it doesn't work, totally. It just reports some error about missing key and exits. From the network communication I found out this is caused by requests to the phabricator server missing the query parameters when reusing HTTP connection fails, however, I don't want to dig deeper into this as it is something between php and curl. Oddly enough it doesn't work on this repository only, other kde repositories work.
And please, if you accepted it, could you also commit it, with the other 2 revisions? I have no commit access.