Add event filter for key press/release events while KWin grabbed keyboard on root window
ClosedPublic

Authored by graesslin on Oct 7 2016, 2:36 PM.

Details

Summary

The modifier-only-shortcuts break as soon as KWin grabs the keyboard
(e.g. alt+tab, present windows, etc.). The investigation shows that in
that case KWin does not get any raw key events any more and thus gets
confused about the state of the hold modifiers. E.g. alt+tab has the
alt key pressed, but we miss the release as the keyboard is grabbed.

This change addresses the problem by installing an additional event
filter for key press and release event which only filters for key events
on the root window. That way we can be sure that it only operates when
KWin grabbed the keyboard on the root window.

Note: the problem only exists when grabbing on the root window. If the
grab is on another window (e.g. moving a window) we still do get all
events.

The problem also seems to not happen if another application grabbed
keys on the root window. E.g. for key combinations grabbed by
kglobalaccel the correct sequence of key press/release as raw events
are reported. Also while the screen is locked the evemts are reported
and kscreenlocker grabs the keyboard on the root window.

Test Plan

Used Alt+Tab and Present Windows and tried to activate launcher
afterwards.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 7203.Oct 7 2016, 2:36 PM
graesslin retitled this revision from to Add event filter for key press/release events while KWin grabbed keyboard on root window.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptOct 7 2016, 2:36 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
hein accepted this revision.Oct 10 2016, 10:20 AM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Oct 10 2016, 10:20 AM
This revision was automatically updated to reflect the committed changes.