Differential D29787

Fix krununittest
ClosedPublic
Actions

Authored by ahmadsamir on May 15 2020, 7:56 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:ef7708d1f5ec: Fix krununittest
Summary

After 6452a34cf01d03d316, DesktopExecParser::resultingArguments() needs
to find the terminal app binary, otherwise it returns an empty QStringList.

Test Plan

krununittest passes again

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.May 15 2020, 7:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 15 2020, 7:56 PM
ahmadsamir requested review of this revision.May 15 2020, 7:56 PM
dfaure accepted this revision.May 16 2020, 8:25 AM

Let's hope the CI has xterm installed.... I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird.

This revision is now accepted and ready to land.May 16 2020, 8:25 AM
Closed by commit R241:ef7708d1f5ec: Fix krununittest (authored by ahmadsamir). · Explain WhyMay 17 2020, 1:55 AM
This revision was automatically updated to reflect the committed changes.
ahmadsamir added a comment.May 17 2020, 9:08 AM
In D29787#672139, @dfaure wrote:

Let's hope the CI has xterm installed.... I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird.

The CI seems to have xterm available as the unit test passed (and then after the switch to gitlab, a new CI setup will be available, let's hope it has xterm too :)).

Revision Contents
Changeset List

PathPackages
Mautotests/krununittest.cpp (12 lines)

Diff 83011

View Options

autotests/krununittest.cpp

Loading...