Fix krununittest
ClosedPublic

Authored by ahmadsamir on Fri, May 15, 7:56 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R241:ef7708d1f5ec: Fix krununittest
Summary

After 6452a34cf01d03d316, DesktopExecParser::resultingArguments() needs
to find the terminal app binary, otherwise it returns an empty QStringList.

Test Plan

krununittest passes again

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Fri, May 15, 7:56 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFri, May 15, 7:56 PM
ahmadsamir requested review of this revision.Fri, May 15, 7:56 PM
dfaure accepted this revision.Sat, May 16, 8:25 AM

Let's hope the CI has xterm installed.... I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird.

This revision is now accepted and ready to land.Sat, May 16, 8:25 AM
This revision was automatically updated to reflect the committed changes.

Let's hope the CI has xterm installed.... I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird.

The CI seems to have xterm available as the unit test passed (and then after the switch to gitlab, a new CI setup will be available, let's hope it has xterm too :)).