Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work)
and another one in jobtest.cpp for a http URL (e.g. to test which error code we're getting, if any?)

+ call mostLocalUrl() on a "normal" StatJob in testtrash.cpp

Thanks.

In D29782#672157, @dfaure wrote:

Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work)

I don't see where the trash ioslave sets UDS_LOCAL_PATH; I think it doesn't set it, I could be wrong, though.

and another one in jobtest.cpp for a http URL (e.g. to test which error code we're getting, if any?)

I'll look into that next.

+ call mostLocalUrl() on a "normal" StatJob in testtrash.cpp

Same as the first point :)

[...]

I've just realised, we won't get an error with an http url; in that case we return the url the statjob was called on as-is and cancel the job.

OK, I picked testtrash because kio_trash *is* a :local protocol. If it doesn't use UDS_LOCAL_PATH, at least it means the job will actually go through (no early filtering out). That's at least interesting to test too.

Good that http will give no error. That's something else the test can check :-)

kio_remote is part of kio and sets UDS_LOCAL_PATH, maybe it can be used for testing the case where we'll actually find a local path. I'm afraid there isn't much testing of that kioslave though, so this sounds like a bigger effort.

This wasn't landed on master, but rather phabricator is confused by me pushing to work/ branch on gitlab :)