diff --git a/kcmkwin/kwinrules/package/contents/ui/FileDialogLoader.qml b/kcmkwin/kwinrules/package/contents/ui/FileDialogLoader.qml --- a/kcmkwin/kwinrules/package/contents/ui/FileDialogLoader.qml +++ b/kcmkwin/kwinrules/package/contents/ui/FileDialogLoader.qml @@ -36,7 +36,7 @@ title: root.title selectExisting: !root.isSaveDialog - folder: (root.lastFolder == "") ? shortcuts.home : root.lastFolder + folder: root.lastFolder || shortcuts.home nameFilters: [ i18n("KWin Rules (*.kwinrule)") ] defaultSuffix: "*.kwinrule" diff --git a/kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml b/kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml --- a/kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml +++ b/kcmkwin/kwinrules/package/contents/ui/OptionsComboBox.qml @@ -91,7 +91,7 @@ QQC2.ToolTip { text: model.tooltip - visible: hovered && (model.tooltip != "") + visible: hovered && (model.tooltip.length > 0) } Component.onCompleted: { diff --git a/kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml b/kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml --- a/kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml +++ b/kcmkwin/kwinrules/package/contents/ui/RuleItemDelegate.qml @@ -106,7 +106,7 @@ QQC2.ToolTip { text: model.description - visible: hovered && (text != "") + visible: hovered && (text.length > 0) } } } diff --git a/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml b/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml --- a/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml +++ b/kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml @@ -154,7 +154,7 @@ Layout.alignment: Qt.AlignVCenter QQC2.ToolTip { text: model.description - visible: hovered && (model.description != "") + visible: hovered && (model.description.length > 0) } } QQC2.Label { @@ -253,7 +253,7 @@ if (!showItem) { return false; } - if (filterString != "") { + if (filterString.length > 0) { return sourceModel.data(index, RulesModel.NameRole).toLowerCase().includes(filterString) } return true; diff --git a/kcmkwin/kwinrules/package/contents/ui/RulesList.qml b/kcmkwin/kwinrules/package/contents/ui/RulesList.qml --- a/kcmkwin/kwinrules/package/contents/ui/RulesList.qml +++ b/kcmkwin/kwinrules/package/contents/ui/RulesList.qml @@ -67,7 +67,7 @@ } Kirigami.PlaceholderMessage { - visible: ruleBookView.count == 0 + visible: ruleBookView.count === 0 anchors.centerIn: parent width: parent.width - (units.largeSpacing * 4) text: i18n("No rules for specific windows are currently set"); @@ -84,7 +84,7 @@ iconName: "object-select-symbolic" text: checked ? i18n("Unselect All") : i18n("Select All") checkable: true - checked: selectedIndexes.length == ruleBookView.count + checked: selectedIndexes.length === ruleBookView.count onToggled: { if (checked) { selectedIndexes = [...Array(ruleBookView.count).keys()]