CopyJob: Check if destination dir is a symlink
ClosedPublic
Actions

Authored by meven on May 15 2020, 6:58 AM.

Details

Reviewers

dfaure
ngraham

Group Reviewers

Frameworks

Commits

Summary

BUG: 421213
FIXED-IN: 5.71

Test Plan

ctest

Repository

R241 KIO

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26929
Build 26947: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

meven requested review of this revision.May 15 2020, 6:58 AM

Remove unrelated change

Thanks for the quick fix and for the test! Just minor issues in comments, feel free to push after fixing.

autotests/jobtest.cpp
626	Typo: symblink
633	remove
648	there is only one symlink ;-) Maybe "The file is visible in both places, due to the symlink" ?

This revision is now accepted and ready to land.May 15 2020, 7:53 AM

review feedback, cleanups

This revision was automatically updated to reflect the committed changes.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82901	6452a34		May 15 2020, 6:58 AM	★	★
Diff 2	82902	6452a34	Remove unrelated change	May 15 2020, 6:59 AM	★	★
Diff 3	82920	6452a34	review feedback, cleanups	May 15 2020, 10:46 AM	★	★
Diff 4	82921	85c06ca	R241:8769b6360d87c1b688eac4d0ce97594351bad13c	May 15 2020, 10:46 AM	★	★