CopyJob: Check if destination dir is a symlink
ClosedPublic

Authored by meven on Fri, May 15, 6:58 AM.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Fri, May 15, 6:58 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFri, May 15, 6:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Fri, May 15, 6:58 AM
meven updated this revision to Diff 82902.Fri, May 15, 6:59 AM

Remove unrelated change

dfaure accepted this revision.Fri, May 15, 7:53 AM

Thanks for the quick fix and for the test! Just minor issues in comments, feel free to push after fixing.

autotests/jobtest.cpp
626

Typo: symblink

633

remove

648

there is only one symlink ;-)

Maybe "The file is visible in both places, due to the symlink" ?

This revision is now accepted and ready to land.Fri, May 15, 7:53 AM
meven updated this revision to Diff 82920.Fri, May 15, 10:46 AM
meven marked 3 inline comments as done.

review feedback, cleanups

This revision was automatically updated to reflect the committed changes.