Differential D29754

Add memory to includes
AbandonedPublic
Actions

Authored by sjolly on May 14 2020, 2:17 PM.

Details

Reviewers
davidedmundson
Summary

I was getting an error regarding unique_ptr not being in the std namespace while building messagelib.

Was able to build it after adding #include<memory>.

Error log: https://pastebin.com/yQKy9WyQ

Diff Detail

Repository
R94 PIM: Message Library
Branch
includeMemory
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26905
Build 26923: arc lint + arc unit
sjolly created this revision.May 14 2020, 2:17 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 14 2020, 2:17 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
sjolly requested review of this revision.May 14 2020, 2:17 PM
davidedmundson accepted this revision.May 14 2020, 2:19 PM
This revision is now accepted and ready to land.May 14 2020, 2:19 PM
sjolly edited the summary of this revision. (Show Details)May 14 2020, 2:20 PM
winterz added a subscriber: winterz.May 14 2020, 7:52 PM

can you commit this ASAP? I'm getting the same compile error.

winterz added a comment.May 14 2020, 7:56 PM

never mind.
I just commited a fix in 76f4c097e9661ff893abd227efef5cd2316b44a9

please abandon this code review.

sjolly abandoned this revision.May 15 2020, 3:13 AM

Revision Contents
Changeset List

Diff 82850

View Options

messagecomposer/src/followupreminder/followupreminderselectdatedialog.h

Loading...