Differential D29744

[Kicker] Fix jump list actions in RunnerMatchesModel
ClosedPublic
Actions

Authored by broulik on May 14 2020, 12:45 PM.

Details

Reviewers
hein
davidedmundson
Group Reviewers
Plasma
Commits
R120:9e545131faa9: [Kicker] Fix jump list actions in RunnerMatchesModel
Summary

Fixes regression caused by me meddling with data in 6e660cf92d7c3fb0e20527866691eaff9f8bc207
Unfortunately KRunner has no notion of "this is application xyz" so Kicker has to make assumptions, which broke here.

Test Plan

5.19 please

  • Searched for firefox, right clicked the result, got "new incognito tab" again
  • Searched for "incognito", got "new incognito tab" result, right clicked, didn't get any jump list actions there purposefully

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.May 14 2020, 12:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 14 2020, 12:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.May 14 2020, 12:45 PM
davidedmundson accepted this revision.May 14 2020, 2:15 PM
This revision is now accepted and ready to land.May 14 2020, 2:15 PM
Closed by commit R120:9e545131faa9: [Kicker] Fix jump list actions in RunnerMatchesModel (authored by broulik). · Explain WhyMay 15 2020, 6:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82900

View Options

applets/kicker/plugin/runnermatchesmodel.cpp

Loading...