Differential D29736

Revert "Improve partial maximization strings"
ClosedPublic
Actions

Authored by zzag on May 14 2020, 5:39 AM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:a68c0959a6f3: Revert "Improve partial maximization strings"
Summary

This reverts commit 45bf53adab9d998126037134b10492437d42e53e.

We cannot change config values for existing users since it will break
their installations.

Diff Detail

Repository
R108 KWin
Branch
change-maximize-only-strings
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26881
Build 26899: arc lint + arc unit
zzag created this revision.May 14 2020, 5:39 AM
Restricted Application added a project: KWin. · View Herald TranscriptMay 14 2020, 5:39 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.May 14 2020, 5:39 AM
zzag added a comment.May 14 2020, 5:40 AM

Note that the message freeze is today.

broulik added a subscriber: broulik.May 14 2020, 5:45 AM
broulik added inline comments.
kcmkwin/kwinoptions/kwinoptions_settings.kcfg
80

Does it not use the name as config key? i.e. should be fine to change the UI file but not the kcfg?

zzag added inline comments.May 14 2020, 5:55 AM
kcmkwin/kwinoptions/kwinoptions_settings.kcfg
80

Unfortunately, no. The value is written to the config while the name is used for generating C++ enums.

bshah added a subscriber: bshah.May 14 2020, 6:18 AM

Hm maybe writing kconf_update script could be nicer?

zzag added a comment.May 14 2020, 6:22 AM
In D29736#670638, @bshah wrote:

Hm maybe writing kconf_update script could be nicer?

I think changing display strings in the kcm would be much simpler.

davidedmundson accepted this revision.May 14 2020, 9:36 AM
davidedmundson added a subscriber: davidedmundson.

Heh, I also assume it used name, but judging from options.cpp that's very very clearly not the case. Sorry for not noticing.

This revision is now accepted and ready to land.May 14 2020, 9:36 AM
davidedmundson added a comment.May 14 2020, 9:38 AM

Note that the message freeze is today.

It's been like this for N years, whilst I'm happy with the new UI strings, this isn't something we need to rush. Lets revert first fix properly later.

Closed by commit R108:a68c0959a6f3: Revert "Improve partial maximization strings" (authored by zzag). · Explain WhyMay 14 2020, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 82809

View Options

kcmkwin/kwinoptions/kwinoptions_settings.kcfg

Loading...
View Options

kcmkwin/kwinoptions/mouse.ui

Loading...
View Options

kwin.kcfg

Loading...
View Options

options.cpp

Loading...