add Umpqua and Wells Fargo bank icons with ABA routing #s
ClosedPublic

Authored by spage on Wed, May 13, 9:58 PM.

Details

Summary

Add these icons to main and US list_bank.txt files.

Test Plan

Run Skrooge, click Accounts, in panel click bank icon popup,
press 'u' or 'w' to scroll nearer to these icons, select the new green or
red new icon, confirm bank name and number appear.

Diff Detail

Repository
R469 Skrooge
Branch
more_logos
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26877
Build 26895: arc lint + arc unit
spage requested review of this revision.Wed, May 13, 9:58 PM
spage created this revision.

Works for me, but I have concerns.

images/logos/l10n/us/list_bank.txt
10

I added these icons to this USA file as well but couldn't figure out how to test, I only see the entire list list.

images/logos/umpqua__123205054.png
1

The other bank icons are all 100 pixels in one dimension or another, but I couldn't find one that big. And in the UI on my 1920-pixel-wide monitors, the icons are shrunk down to 16x16 in the Accounts tab and the header of the Operations tab and so badly pixelated anyway. Maybe 96x96 images or some other multiple of 16 would resize down with less distortion?

This PNG has a transparent background but seems to work fine.

images/logos/wells_fargo__121000248.png
1

Looks fabulous here, looks terrible in the app πŸ‘€

Stephane, should I file a bug for this addition?

spage added a comment.Wed, Jun 3, 2:04 AM

Bonjour @smankowski , I think I figured out Differential and Arcanist just in time for the move to invent/GitLab πŸ˜‰ . Do you want me to re-submit this in invent/GitLab? I'll have the same questions there about icon sizes...

smankowski accepted this revision.Wed, Jun 3, 12:01 PM

You can commit it.

This revision is now accepted and ready to land.Wed, Jun 3, 12:01 PM
spage closed this revision.Wed, Jun 3, 10:29 PM