Differential D29720

Support mulitple data devices on a single client
ClosedPublic
Actions

Authored by davidedmundson on May 13 2020, 3:59 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Summary

Firefox has two wl_data_devices. One in firefox code one in GTK code.
Both need to get data offers.

I've left handling the case for multiple data devices and drags to make
this patch feasible to put into 5.19 and I didn't want to make this
patch invasive.

Test Plan

Firefox in wayland
WAYLAND_DEBUG=1 firefox |& grep data
Shows now both created devices get offers
Also I can paste

Diff Detail

Branch
Plasma/5.19
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 27012
Build 27030: arc lint + arc unit
davidedmundson requested review of this revision.May 13 2020, 3:59 PM
davidedmundson created this revision.
zzag accepted this revision.May 13 2020, 4:19 PM
zzag added a subscriber: zzag.
zzag added inline comments.
src/server/seat_interface.cpp
651

This needs to be marked as a TODO comment. Could you please put "TODO:" or something?

This revision is now accepted and ready to land.May 13 2020, 4:19 PM
ngraham added a subscriber: ngraham.May 13 2020, 6:30 PM

Nice, pasting is fixed!

davidedmundson updated this revision to Diff 83034.May 18 2020, 8:45 AM

Add TODO

Rebase to be against 5.19

meven added a subscriber: meven.EditedMay 18 2020, 10:02 AM
In D29720#672581, @davidedmundson wrote:

Add TODO

Where ? I don't see it in the code.

davidedmundson closed this revision.May 21 2020, 10:06 AM

This was merged (with the TODO comment added)
Just not autoclosed due to the gitlab migration.

Revision Contents
Changeset List

Diff 83034

View Options

src/server/seat_interface.cpp

Loading...
View Options

src/server/seat_interface_p.h

Loading...