[Fonts KCM] Remove last remnants of setNearestExistingFonts()
AcceptedPublic

Authored by ahmadsamir on Wed, May 13, 2:29 PM.

Details

Reviewers
bport
broulik
ngraham
Group Reviewers
Plasma
Summary

This cleans up after commit 0325d698181055cdaaa93.

Test Plan

make && ctest

Diff Detail

Repository
R119 Plasma Desktop
Branch
l-neareast-addendum (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26843
Build 26861: arc lint + arc unit
ahmadsamir created this revision.Wed, May 13, 2:29 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, May 13, 2:29 PM
ahmadsamir requested review of this revision.Wed, May 13, 2:29 PM

Also, is it OK to backport https://commits.kde.org/plasma-desktop/0325d698181055cdaaa93b24ee80172132822d35 and this diff to Plasma/5.18?

Scratch that, 5.18 min. required KF is 5.66, and the KFontChooserDialog is only in KF 5.69.

ngraham accepted this revision.Wed, May 13, 3:55 PM
ngraham added a subscriber: ngraham.

For the stable branch, we will need a patch that conditionally disables all of this stuff if you happen to have Frameworks 5.69 or newer. We don't want the stable branch to be broken for distros that are good citizens and ship newer frameworks versions for their discrete releases as we ask of them.

This revision is now accepted and ready to land.Wed, May 13, 3:55 PM

Continuing the discussion from IRC, plasma 5.18 branch still uses QFontDialog, so https://bugs.kde.org/show_bug.cgi?id=420287 isn't directly related. However if users remove the ',Regular' bit from kdeglobals, QFontDialog will probably select the wrong style sometimes...