Port "sorry, nothing found" message to Kirigami.PlaceholderMessage
ClosedPublic

Authored by ngraham on May 12 2020, 6:16 PM.

Diff Detail

Repository
R134 Discover Software Store
Branch
port-to-placeholdermessage (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26804
Build 26822: arc lint + arc unit
ngraham created this revision.May 12 2020, 6:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 12 2020, 6:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.May 12 2020, 6:16 PM
filipf accepted this revision.May 12 2020, 7:05 PM
filipf added a subscriber: filipf.
filipf added inline comments.
discover/qml/ApplicationsListPage.qml
149–150

Probably worth it to port this to NumberAnimation at a different time since Marco said it's more efficient.

151

Should work without this, no?

This revision is now accepted and ready to land.May 12 2020, 7:05 PM
ngraham updated this revision to Diff 82687.May 12 2020, 7:08 PM
ngraham marked 2 inline comments as done.

Address review comments

filipf accepted this revision.May 12 2020, 7:14 PM

Works well and looks good.

This revision was automatically updated to reflect the committed changes.